Skip to content

src: remove calls to deprecated v8 functions (NumberValue) #22094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryzokuken wants to merge 3 commits into from
Closed

src: remove calls to deprecated v8 functions (NumberValue) #22094

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2eb2c9c
src: remove calls to deprecated v8 functions (NumberValue)
ryzokuken Aug 2, 2018
feb53d1
fixup! src: remove calls to deprecated v8 functions (NumberValue)
ryzokuken Aug 3, 2018
8a5affd
fixup! src: remove calls to deprecated v8 functions (NumberValue)
ryzokuken Aug 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: remove calls to deprecated v8 functions (NumberValue)
  • Loading branch information
@ryzokuken
ryzokuken committed Aug 4, 2018
commit 8a5affd01fe49ee505ed1fab69a7a185928f73c2
2 changes: 1 addition & 1 deletion src/async_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ void AsyncWrap::QueueDestroyAsyncId(const FunctionCallbackInfo<Value>& args) {
CHECK(args[0]->IsNumber());
AsyncWrap::EmitDestroy(
Environment::GetCurrent(args),
args[0]->NumberValue(args.GetIsolate()->GetCurrentContext()).ToChecked());
args[0].As<Number>()->Value());
}

void AsyncWrap::AddWrapMethods(Environment* env,
Expand Down