Skip to content

test: handling failure cases properly #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thefourtheye wants to merge 2 commits into from
Closed

test: handling failure cases properly #2206

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
584c40b
test: handling failure cases properly
thefourtheye Jul 19, 2015
df94616
Addressing Ben's comments
thefourtheye Aug 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Addressing Ben's comments
  • Loading branch information
@thefourtheye
thefourtheye committed Aug 5, 2015
commit df946163dd50dcd80dd1d620c199f4ecfa6fac17
9 changes: 3 additions & 6 deletions test/parallel/test-cluster-eaccess.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
// test that errors propagated from cluster workers are properly
// Test that errors propagated from cluster workers are properly
// received in their master. Creates an EADDRINUSE condition by forking
// a process in child cluster and propagates the error to the master.

Expand Down Expand Up @@ -31,15 +31,12 @@ if (cluster.isMaster) {
console.log('master exited');
try {
fs.unlinkSync(common.PIPE);
} catch (ex) {
if (ex.code !== 'ENOENT') {
throw ex;
}
} catch (e) {
}
});

} else {
const cp = fork(common.fixturesDir + '/listen-on-socket-and-exit.js',
var cp = fork(common.fixturesDir + '/listen-on-socket-and-exit.js',
{ stdio: 'inherit' });
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Aug 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a style error, the arguments don't line up. I have to admit I'm not a big fan of random style changes, they make the diff a lot noisier (and hence harder to read) than it needs to be.

Copy link
Copy Markdown
Contributor Author

@thefourtheye thefourtheye Aug 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it as is now.


// message from the child indicates it's ready and listening
Expand Down