Skip to content

inspector: fixed V8InspectorClient::currentTimeMS method #21917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexkozy wants to merge 1 commit into from
Closed

inspector: fixed V8InspectorClient::currentTimeMS method #21917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
inspector: fixed V8InspectorClient::currentTimeMS method 
On inspector side inside V8 we assume that this method should
return number of ms since epoch.
  • Loading branch information
@alexkozy
alexkozy committed Jul 21, 2018
commit 31a01fb0dcb158cc5e3967dc4fe02e802cb1859f
4 changes: 1 addition & 3 deletions src/inspector_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,6 @@ static int StartDebugSignalHandler() {
#endif // _WIN32


// Used in NodeInspectorClient::currentTimeMS() below.
const int NANOS_PER_MSEC = 1000000;
const int CONTEXT_GROUP_ID = 1;

class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
Expand Down Expand Up @@ -593,7 +591,7 @@ class NodeInspectorClient : public V8InspectorClient {
}

double currentTimeMS() override {
return uv_hrtime() * 1.0 / NANOS_PER_MSEC;
return env_->isolate_data()->platform()->CurrentClockTimeMillis();
}

node::Environment* env_;
Expand Down