Skip to content

tools: validate apidoc links #21889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubys wants to merge 5 commits into from
Closed

tools: validate apidoc links #21889

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d07e27
tools: validate apidoc links
rubys Jul 19, 2018
fc0c16d
object => set
rubys Jul 19, 2018
c3d8ee9
comment punctuation
rubys Jul 19, 2018
f8cf61b
.replace => .exec
rubys Jul 19, 2018
930d192
camelCase
rubys Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
camelCase
  • Loading branch information
@rubys
rubys committed Jul 20, 2018
commit 930d192e0e5cbfd6ec1146850932712e2327ab4b
8 changes: 4 additions & 4 deletions tools/doc/allhtml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ fs.writeFileSync(source + '/all.html', all, 'utf8');

// Validate all hrefs have a target.
const ids = new Set();
const id_re = / id="(\w+)"/g;
const idRe = / id="(\w+)"/g;
let match;
while (match = id_re.exec(all)) {
while (match = idRe.exec(all)) {
ids.add(match[1]);
}

const href_re = / href="#(\w+)"/g;
while (match = href_re.exec(all)) {
const hrefRe = / href="#(\w+)"/g;
while (match = hrefRe.exec(all)) {
if (!ids.has(match[1])) throw new Error(`link not found: ${match[1]}`);

This comment was marked as resolved.

Sign in to view

Copy link
Copy Markdown
Member Author

@rubys rubys Jul 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think efficiency is a concern here... it will only be retrieved twice at most one time per run, and only if an error is thrown.

}