Skip to content

performance,events: use Map to store events in EventEmitter #21856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lundibundi wants to merge 3 commits into from
Closed

performance,events: use Map to store events in EventEmitter #21856

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
246c7ca
events: use Map in events.js to store _events
lundibundi Jul 16, 2018
a3af552
fixup! implement proxy for each EE, add benchmarks
lundibundi Jul 17, 2018
e694796
try V8 fix of limiting Map shrink until capacity >= 16
lundibundi Jul 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
try V8 fix of limiting Map shrink until capacity >= 16
  • Loading branch information
@lundibundi
lundibundi committed Jul 22, 2018
commit e694796a0de9c420f06bb95ce9344d702182278f
15 changes: 9 additions & 6 deletions deps/v8/src/builtins/builtins-collections-gen.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1474,14 +1474,17 @@ TF_BUILTIN(MapPrototypeDelete, CollectionsBuiltinsAssembler) {
LoadFixedArrayElement(table, OrderedHashMap::kNumberOfBucketsIndex);

// If there fewer elements than #buckets / 2, shrink the table.
Label shrink(this);
GotoIf(SmiLessThan(SmiAdd(number_of_elements, number_of_elements),
number_of_buckets),
&shrink);
Return(TrueConstant());
Label dont_shrink(this);
GotoIf(SmiGreaterThanOrEqual(SmiAdd(number_of_elements, number_of_elements),
number_of_buckets),
&dont_shrink);
// If #buckets is less than 8 then don't shrink the table
GotoIf(SmiLessThan(number_of_buckets, SmiConstant(8)),
&dont_shrink);

BIND(&shrink);
CallRuntime(Runtime::kMapShrink, context, receiver);

BIND(&dont_shrink);
Return(TrueConstant());
}

Expand Down