Skip to content

fs: improve fs.watch ENOSPC error message #21846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

fs: improve fs.watch ENOSPC error message #21846

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73f4325
fs: improve fs.watch ENOSPC error message
addaleax Jul 17, 2018
310fdd4
fixup! fs: improve fs.watch ENOSPC error message
addaleax Sep 11, 2018
f4f948a
fixup! fs: improve fs.watch ENOSPC error message
addaleax Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fs: improve fs.watch ENOSPC error message
  • Loading branch information
@addaleax
addaleax committed Sep 11, 2018
commit 310fdd41efe6973c004ad8bc4ad65bd2ceb46001
2 changes: 1 addition & 1 deletion lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ function getMessage(key, args) {
*/
function uvException(ctx) {
const [ code, uvmsg ] = errmap.get(ctx.errno);
let message = `${code}: ${ctx.description || uvmsg}, ${ctx.syscall}`;
let message = `${code}: ${ctx.message || uvmsg}, ${ctx.syscall}`;

let path;
let dest;
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/fs/watchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ FSWatcher.prototype.start = function(filename,
errno: err,
syscall: 'watch',
path: filename,
description: err === UV_ENOSPC ?
message: err === UV_ENOSPC ?
'System limit for number of file watchers reached' : ''
});
error.filename = filename;
Expand Down
1 change: 0 additions & 1 deletion test/sequential/test-fs-watch-system-limit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ spawnProcesses();
let accumulated = '';
gatherStderr.on('data', common.mustCallAtLeast((chunk) => {
accumulated += chunk;
// console.log(chunk);
if (accumulated.includes('Error:') && !finished) {
assert(
accumulated.includes('ENOSPC: System limit for number ' +
Expand Down