Skip to content

repl: support mult-line string-keyed objects #21805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubys wants to merge 7 commits into from
Closed

repl: support mult-line string-keyed objects #21805

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9affc6f
repl: support mult-line string-keyed objects
rubys Jul 13, 2018
7bb9bf1
parser. => this. and acorn.tokTypes => tt
rubys Jul 14, 2018
d426b00
split out isRecoverableError, changed call to Reflect.apply.
rubys Jul 15, 2018
974b337
s/plugins.repl/plugins.replRecoverable/g
rubys Jul 15, 2018
02c5827
all Line Terminators matter
rubys Jul 18, 2018
e58b861
token.match() => .test(token)
rubys Jul 19, 2018
d426d86
remove unused exception variable
rubys Jul 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
all Line Terminators matter
  • Loading branch information
@rubys
rubys committed Aug 2, 2018
commit 02c5827c32da84770a6697af65d66e076b4312a1
3 changes: 2 additions & 1 deletion lib/internal/repl/recoverable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ function isRecoverableError(e, code) {

case 'Unterminated string constant':
const token = this.input.slice(this.lastTokStart, this.pos);
recoverable = token.endsWith('\\\n');
// see https://www.ecma-international.org/ecma-262/#sec-line-terminators
recoverable = token.match(/\\(\r\n?|\n|\u2028|\u2029)$/);
}
Copy link
Copy Markdown
Member

@jdalton jdalton Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token.match() will return an array or null.
You probably want /\\(?:\r\n?|\n|\u2028|\u2029)$/.test(token).


Reflect.apply(raise, this, [pos, message]);
Expand Down