Skip to content

test: add gc tracking API to common, refactor pummel net test + move it to parallel #21794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

test: add gc tracking API to common, refactor pummel net test + move it to parallel #21794

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0642e68
test: add gc tracking to common API
addaleax Jul 13, 2018
96c1b99
test: refactor test-net-connect-memleak, move to parallel
addaleax Jul 13, 2018
ed98029
test: refactor test-tls-connect-memleak, move to parallel
addaleax Jul 13, 2018
24bd33b
fixup! test: add gc tracking to common API
addaleax Jul 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: refactor test-tls-connect-memleak, move to parallel 
This enables the test to run as part of the regular test suite.
  • Loading branch information
@addaleax
addaleax committed Jul 13, 2018
commit ed980296631860211a523fdb433550af1bc49440
46 changes: 23 additions & 23 deletions test/pummel/test-tls-connect-memleak.js → test/parallel/test-tls-connect-memleak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,36 +30,36 @@ const assert = require('assert');
const tls = require('tls');
const fixtures = require('../common/fixtures');

assert.strictEqual(
typeof global.gc,
'function',
`Type of global.gc is not a function. Type: ${typeof global.gc}.` +
' Run this test with --expose-gc'
);
// Test that the implicit listener for an 'connect' event on tls.Sockets is
// added using `once()`, i.e. can be gc'ed once that event has occurred.

tls.createServer({
const server = tls.createServer({
cert: fixtures.readSync('test_cert.pem'),
key: fixtures.readSync('test_key.pem')
}).listen(common.PORT);
}).listen(0);

let collected = false;
const gcListener = { ongc() { collected = true; } };

{
// 2**26 == 64M entries
const junk = new Array(2 ** 26).fill(0);
const gcObject = {};
common.onGC(gcObject, gcListener);

const options = { rejectUnauthorized: false };
tls.connect(common.PORT, '127.0.0.1', options, function() {
assert.notStrictEqual(junk.length, 0); // keep reference alive
setTimeout(done, 10);
global.gc();
});
const sock = tls.connect(
server.address().port,
{ rejectUnauthorized: false },
common.mustCall(() => {
assert.strictEqual(gcObject, gcObject); // keep reference alive
assert.strictEqual(collected, false);
setImmediate(done, sock);
}));
}

function done() {
const before = process.memoryUsage().rss;
function done(sock) {
global.gc();
const after = process.memoryUsage().rss;
const reclaimed = (before - after) / 1024;
console.log('%d kB reclaimed', reclaimed);
assert(reclaimed > 256 * 1024); // it's more like 512M on x64
process.exit();
setImmediate(() => {
assert.strictEqual(collected, true);
sock.end();
server.close();
});
}