Skip to content

trace_events: add more process metadata #21785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

trace_events: add more process metadata #21785

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e55bab0
trace_events: add more process metadata
jasnell Jul 12, 2018
2f37de4
[Squash] Use a TraceStateObserver
jasnell Jul 12, 2018
8e2c8c9
[Squash] missed a delete
jasnell Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Squash] missed a delete
  • Loading branch information
@jasnell
jasnell committed Jul 12, 2018
commit 8e2c8c9b94ad2402126c19c44f4b59152e6da250
2 changes: 0 additions & 2 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2147,8 +2147,6 @@ void SetupProcessObject(Environment* env,
READONLY_PROPERTY(release, "name",
OneByteString(env->isolate(), NODE_RELEASE));

auto traced_release = tracing::TracedValue::Create();

#if NODE_VERSION_IS_LTS
READONLY_PROPERTY(release, "lts",
OneByteString(env->isolate(), NODE_VERSION_LTS_CODENAME));
Expand Down