Skip to content

stream: flow for 'data' listeners upon removal of last 'readable' listener #21696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lundibundi wants to merge 3 commits into from
Closed

stream: flow for 'data' listeners upon removal of last 'readable' listener #21696

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fa9528
stream: flow for 'data' listeners upon 'readable' remove
lundibundi Jul 6, 2018
c07abd7
stream: postpone setting flowing for on('readable')
lundibundi Aug 9, 2018
d699f48
fixup! stream: postpone setting flowing for on('readable')
lundibundi Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! stream: postpone setting flowing for on('readable')
  • Loading branch information
@lundibundi
lundibundi committed Aug 9, 2018
commit d699f4839a03bee617f568502ef4351b62a4b91d
2 changes: 1 addition & 1 deletion test/parallel/test-stream-readable-reading-readingMore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ const Readable = require('stream').Readable;
readable.push('pushed');

// we are still not flowing, we will be resuming in the next tick
assert.strictEqual(state.flowing, false);
assert.strictEqual(state.flowing, null);

// wait for nextTick, so the readableListener flag resets
process.nextTick(function() {
Expand Down