Skip to content

console: console.countReset() should emit warning #21649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domfarolino wants to merge 2 commits into from
Closed

console: console.countReset() should emit warning #21649

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac53ee5
console: console.countReset() should emit warning
domfarolino Jun 18, 2018
033f41e
Finish rebase + update console label
domfarolino Jul 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Finish rebase + update console label
  • Loading branch information
@domfarolino
domfarolino committed Jul 4, 2018
commit 033f41e7fb40e95becca3c040ca6593d450a3936
10 changes: 5 additions & 5 deletions test/parallel/test-console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ common.expectWarning(
'Warning',
[
['Count for \'noLabel\' does not exist', common.noWarnCode],
['No such label \'nolabel\' for console.timeLog()', common.noWarnCode],
['No such label \'nolabel\' for console.timeEnd()', common.noWarnCode],
['No such label \'noLabel\' for console.timeLog()', common.noWarnCode],
['No such label \'noLabel\' for console.timeEnd()', common.noWarnCode],
['Label \'test\' already exists for console.time()', common.noWarnCode]
]
);

console.countReset('noLabel');
console.timeLog('nolabel');
console.timeEnd('nolabel');
console.timeLog('noLabel');
console.timeEnd('noLabel');

console.time('label');
console.timeEnd('label');
Expand Down Expand Up @@ -247,6 +247,6 @@ common.hijackStderr(common.mustCall(function(data) {

// stderr.write will catch sync error, so use `process.nextTick` here
process.nextTick(function() {
assert.strictEqual(data.includes('nolabel'), true);
assert.strictEqual(data.includes('noLabel'), true);
});
}));