Skip to content

test: add tests for dnsPromises.lookup #21559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shisama wants to merge 2 commits into from
+25 −0
Closed

test: add tests for dnsPromises.lookup #21559

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a2cfcc
test: add tests for dnsPromises.lookup
Jun 27, 2018
116f6eb
test: remove tests that require the Internet in test-dns-lookup
Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: remove tests that require the Internet in test-dns-lookup
  • Loading branch information
Masashi Hirano committed Aug 13, 2018
commit 116f6eb2a22288d3d9eb1f835f564cda1552b405
15 changes: 0 additions & 15 deletions test/parallel/test-dns-lookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,21 +97,6 @@ common.expectsError(() => {
});
assert.deepStrictEqual(res, { address: '127.0.0.1', family: 4 });

res = await dnsPromises.lookup(addresses.INET4_HOST, {
hints: 0,
family: 4,
all: false
});
assert.strictEqual(res.family, 4);

res = await dnsPromises.lookup(addresses.INET4_HOST, {
hints: 0,
family: 4,
all: true
});
assert.ok(res.length > 0);
res.forEach((obj) => { assert.strictEqual(obj.family, 4); });

assert.rejects(
dnsPromises.lookup(addresses.INVALID_HOST, {
hints: 0,
Expand Down