Skip to content

benchmark: add n-api function arguments benchmark suite #21555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kenny-y wants to merge 8 commits into from
Closed

benchmark: add n-api function arguments benchmark suite #21555

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6aa13a1
benchmark: add n-api function arguments benchmark suite
kenny-y Jun 27, 2018
cb758e9
Some fine adjustment based on the review comments in
kenny-y Jun 28, 2018
75e6e42
Fixed wrong calc of typedarray offset (result not in use)
kenny-y Jun 29, 2018
173fa80
Removing compiler warnings
kenny-y Jul 2, 2018
10f3fc5
Use benchmark suite feature to match every engines with every args-types
kenny-y Jul 2, 2018
f10939a
Fixing macro styling issue, trailing backslash alignment.
kenny-y Jul 4, 2018
645f38e
Change the local casual macro to a more formal one.
kenny-y Jul 4, 2018
0f6b238
Use only one param alignment style in the helper macro.
kenny-y Jul 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change the local casual macro to a more formal one.
  • Loading branch information
@kenny-y
kenny-y committed Jul 4, 2018
commit 645f38e87553a43b5f56f692f7afc58c5b2654eb
40 changes: 20 additions & 20 deletions benchmark/napi/function_args/napi_binding.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,39 +189,39 @@ static napi_value CallWithArguments(napi_env env, napi_callback_info info) {
}


#define EXPORT_FUNC(name, func) \
#define EXPORT_FUNC(env, exports, name, func) \
do { \
napi_value func ## _v; \
status = napi_create_function(env, \
name, \
napi_status status; \
napi_value js_func; \
status = napi_create_function((env), \
(name), \
NAPI_AUTO_LENGTH, \
func, \
(func), \
NULL, \
&func ## _v); \
&js_func); \
assert(status == napi_ok); \
status = napi_set_named_property(env, exports, name, func ## _v); \
status = napi_set_named_property((env), \
Copy link
Copy Markdown
Contributor

@gabrielschulhof gabrielschulhof Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Align arguments as with the previous call.

(exports), (name), js_func); \
assert(status == napi_ok); \
} while (0);
Copy link
Copy Markdown
Contributor

@gabrielschulhof gabrielschulhof Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The trailing backslashes must be aligned to the column of the outermost trailing backslash.



NAPI_MODULE_INIT() {
napi_status status;

EXPORT_FUNC("callWithString", CallWithString);
EXPORT_FUNC("callWithLongString", CallWithString);
EXPORT_FUNC(env, exports, "callWithString", CallWithString);
EXPORT_FUNC(env, exports, "callWithLongString", CallWithString);

EXPORT_FUNC("callWithArray", CallWithArray);
EXPORT_FUNC("callWithLargeArray", CallWithArray);
EXPORT_FUNC("callWithHugeArray", CallWithArray);
EXPORT_FUNC(env, exports, "callWithArray", CallWithArray);
EXPORT_FUNC(env, exports, "callWithLargeArray", CallWithArray);
EXPORT_FUNC(env, exports, "callWithHugeArray", CallWithArray);

EXPORT_FUNC("callWithNumber", CallWithNumber);
EXPORT_FUNC(env, exports, "callWithNumber", CallWithNumber);

EXPORT_FUNC("callWithObject", CallWithObject);
EXPORT_FUNC("callWithTypedarray", CallWithTypedarray);
EXPORT_FUNC(env, exports, "callWithObject", CallWithObject);
EXPORT_FUNC(env, exports, "callWithTypedarray", CallWithTypedarray);

EXPORT_FUNC("callWith10Numbers", CallWithArguments);
EXPORT_FUNC("callWith100Numbers", CallWithArguments);
EXPORT_FUNC("callWith1000Numbers", CallWithArguments);
EXPORT_FUNC(env, exports, "callWith10Numbers", CallWithArguments);
EXPORT_FUNC(env, exports, "callWith100Numbers", CallWithArguments);
EXPORT_FUNC(env, exports, "callWith1000Numbers", CallWithArguments);

return exports;
}