Skip to content

test: remove the third string literal argument from assert.strictEqual() #21406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevintab95 wants to merge 1 commit into from
Closed

test: remove the third string literal argument from assert.strictEqual() #21406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove the third string literal argument from assert.strictEqual() 
Third string literal argument in assert.strictEqual() needs to be
removed. Otherwise, on AssertionError it would not display the
values that failed the check -- this hinders debugging.
The string literals are added as comments above the check.
  • Loading branch information
@kevintab95
kevintab95 committed Jun 19, 2018
commit f3f0f987bd91ce9ab0f43ce0fc3c6ef36e3743c9
6 changes: 4 additions & 2 deletions test/parallel/test-string-decoder-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,10 @@ function testBuf(encoding, buf) {
// .toString() on the buffer
const res3 = buf.toString(encoding);

assert.strictEqual(res1, res3, 'one byte at a time should match toString');
assert.strictEqual(res2, res3, 'all bytes at once should match toString');
// One byte at a time should match toString
assert.strictEqual(res1, res3);
// All bytes at once should match toString
assert.strictEqual(res2, res3);
}

function testEnd(encoding, incomplete, next, expected) {
Expand Down