Skip to content

tools: lint doc/*.md files #21361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 6 commits into from
Closed

tools: lint doc/*.md files #21361

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2e6a60e
doc: wrap releases.md at 80 chars
Trott Jun 15, 2018
d65c3cd
doc: correct styling of _GitHub_ in onboarding doc
Trott Jun 15, 2018
7f586a3
doc: remove linking of url text to url
Trott Jun 15, 2018
2b1e711
doc: wrap pull-requests.md at 80 characters
Trott Jun 15, 2018
302c2e0
doc: wrap style guide at 80 characters
Trott Jun 15, 2018
e79f037
tools: lint doc/*.md files
Trott Jun 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: remove linking of url text to url 
Linking URL text to itself is superfluous. It will display as a link in
GitHub anyway. Bonus: This makes it possible to wrap the line at 80
characters.
  • Loading branch information
@Trott
Trott committed Jun 15, 2018
commit 7f586a31492ae64f9ec3f6bd393722a009701bf6
3 changes: 1 addition & 2 deletions doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ needs to be pointed out separately during the onboarding.
## Exercise: Make a PR adding yourself to the README

* Example:
[https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0][]
https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0
* For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0
-1`
* Collaborators are in alphabetical order by GitHub username.
Expand Down Expand Up @@ -250,7 +250,6 @@ needs to be pointed out separately during the onboarding.
[`git-node`]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
[`node-core-utils`]: https://github.com/nodejs/node-core-utils
[Landing Pull Requests]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests
[https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0]: https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0
[Publicizing or hiding organization membership]: https://help.github.com/articles/publicizing-or-hiding-organization-membership/
[set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials
[two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/
Expand Down