Skip to content

http2: fix memory leak for uncommon headers #21336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

http2: fix memory leak for uncommon headers #21336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
http2: fix memory leak for uncommon headers 
Fix a memory leak that occurs with header names that are
short and not present in the static table of default headers.
  • Loading branch information
@addaleax
addaleax committed Jun 15, 2018
commit 2415796651c581bb9945e0c24efde6222b589a9a
1 change: 1 addition & 0 deletions src/node_http2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,6 +1203,7 @@ class ExternalHeader :
}

if (may_internalize && vec.len < 64) {
nghttp2_rcbuf_decref(buf);
// This is a short header name, so there is a good chance V8 already has
// it internalized.
return GetInternalizedString(env, vec);
Expand Down