Skip to content

workers: initial implementation #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petkaantonov wants to merge 10 commits into from
Closed

workers: initial implementation #2133

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
22020dc
Add lock free message queue
petkaantonov Feb 13, 2016
682fc68
add worker tests
petkaantonov Feb 13, 2016
3910d0d
Extract ContextifyScript to a header
petkaantonov Feb 13, 2016
19db86a
Cleanup when environment exits
petkaantonov Feb 13, 2016
1365538
Add RAII locking
petkaantonov Feb 13, 2016
3b54e70
Heap allocated jsstring char* conversion
petkaantonov Feb 13, 2016
1a20880
add static assert
petkaantonov Feb 13, 2016
67d7af5
Clear errors on return
petkaantonov Feb 13, 2016
2dd7f77
Protect global APIs with locks
petkaantonov Feb 13, 2016
7ece8d7
workers: initial implementation
petkaantonov Feb 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clear errors on return
  • Loading branch information
@petkaantonov
petkaantonov committed Feb 13, 2016
commit 67d7af5fc6fc54eb47ac7264dbeb4f1125af869a
21 changes: 21 additions & 0 deletions src/node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4724,6 +4724,9 @@ void ECDH::New(const FunctionCallbackInfo<Value>& args) {
void ECDH::GenerateKeys(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

ClearErrorOnReturn clear_error_on_return;
(void) &clear_error_on_return; // Silence compiler warning.

ECDH* ecdh = Unwrap<ECDH>(args.Holder());

if (!EC_KEY_generate_key(ecdh->key_))
Expand All @@ -4735,6 +4738,9 @@ EC_POINT* ECDH::BufferToPoint(char* data, size_t len) {
EC_POINT* pub;
int r;

ClearErrorOnReturn clear_error_on_return;
(void) &clear_error_on_return; // Silence compiler warning.

pub = EC_POINT_new(group_);
if (pub == nullptr) {
env()->ThrowError("Failed to allocate EC_POINT for a public key");
Expand Down Expand Up @@ -4763,6 +4769,9 @@ EC_POINT* ECDH::BufferToPoint(char* data, size_t len) {
void ECDH::ComputeSecret(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

ClearErrorOnReturn clear_error_on_return;
(void) &clear_error_on_return; // Silence compiler warning.

THROW_AND_RETURN_IF_NOT_BUFFER(args[0]);

ECDH* ecdh = Unwrap<ECDH>(args.Holder());
Expand Down Expand Up @@ -4796,6 +4805,9 @@ void ECDH::ComputeSecret(const FunctionCallbackInfo<Value>& args) {
void ECDH::GetPublicKey(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

ClearErrorOnReturn clear_error_on_return;
(void) &clear_error_on_return; // Silence compiler warning.

// Conversion form
CHECK_EQ(args.Length(), 1);

Expand Down Expand Up @@ -4831,6 +4843,9 @@ void ECDH::GetPublicKey(const FunctionCallbackInfo<Value>& args) {
void ECDH::GetPrivateKey(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

ClearErrorOnReturn clear_error_on_return;
(void) &clear_error_on_return; // Silence compiler warning.

ECDH* ecdh = Unwrap<ECDH>(args.Holder());

const BIGNUM* b = EC_KEY_get0_private_key(ecdh->key_);
Expand All @@ -4855,6 +4870,9 @@ void ECDH::GetPrivateKey(const FunctionCallbackInfo<Value>& args) {
void ECDH::SetPrivateKey(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

ClearErrorOnReturn clear_error_on_return;
(void) &clear_error_on_return; // Silence compiler warning.

ECDH* ecdh = Unwrap<ECDH>(args.Holder());

THROW_AND_RETURN_IF_NOT_BUFFER(args[0]);
Expand Down Expand Up @@ -4908,6 +4926,9 @@ void ECDH::SetPrivateKey(const FunctionCallbackInfo<Value>& args) {
void ECDH::SetPublicKey(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

ClearErrorOnReturn clear_error_on_return;
(void) &clear_error_on_return; // Silence compiler warning.

ECDH* ecdh = Unwrap<ECDH>(args.Holder());

THROW_AND_RETURN_IF_NOT_BUFFER(args[0]);
Expand Down