Skip to content

Require perf optimization #21300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 38 commits into from
Closed

Require perf optimization #21300

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ca6b414
module: optimize require performance
mapleeit Jun 12, 2018
21b14d2
module: fix bug when parent is null
mapleeit Jun 12, 2018
9e5c554
module: fix require.resolve case
mapleeit Jun 13, 2018
8941fb7
inspector: stop dragging platform pointer
Jun 8, 2018
2749460
doc: make Deprecation cycle explanation more brief
Trott Jun 13, 2018
772d390
deps: float ea7abee from openssl / CVE-2018-0732
rvagg Jun 12, 2018
0179e94
test: fix deprecation warning due to util.print
tniessen Jun 11, 2018
a703df9
crypto: fix behavior of createCipher in wrap mode
tniessen Jun 12, 2018
17e378b
perf_hooks: set bootstrap complete in only one place
jasnell Jun 3, 2018
b55f6a0
perf_hooks: remove less useful bootstrap marks
jasnell Jun 3, 2018
a24b691
workers,trace_events: set thread name for workers
jasnell Jun 10, 2018
dcad7c9
doc: switch the order of Writable and Readable
Jun 14, 2018
b505d2a
Revert "workers,trace_events: set thread name for workers"
jasnell Jun 15, 2018
0aa242e
doc: wrap releases.md at 80 chars
Trott Jun 15, 2018
0351f9a
doc: correct styling of _GitHub_ in onboarding doc
Trott Jun 15, 2018
0b27cb4
doc: remove linking of url text to url
Trott Jun 15, 2018
dc10ddf
doc: wrap pull-requests.md at 80 characters
Trott Jun 15, 2018
dabcd47
doc: wrap style guide at 80 characters
Trott Jun 15, 2018
ff00a76
tools: lint doc/*.md files
Trott Jun 15, 2018
859a8d1
doc: use Class Method label consistently
Trott Jun 15, 2018
f56c965
doc: fix heading of optional console method args
targos Jun 13, 2018
1da8855
doc: fix indentation in console.md
vsemozhetbyt Jun 16, 2018
1e54c24
http2: fix memory leak for uncommon headers
addaleax Jun 15, 2018
54ee8cb
src: remove unused argc var in node_stat_watcher
danbev Jun 15, 2018
1d8a231
process: implement process.hrtime.bigint()
joyeecheung Jun 11, 2018
7012950
doc: add davisjam to collaborators
davisjam Jun 11, 2018
452d73d
doc: remove obsolete wiki references from BUILDING
Trott Jun 16, 2018
b6b019f
doc: use imperative in COLLABORATOR_GUIDE
Trott Jun 15, 2018
a13eba7
tools: do not disable `quotes` rule in .eslintrc.js
Trott Jun 15, 2018
64de66d
net: emit 'close' when socket ends before connect
Jun 12, 2018
8fa640e
loader: remove unused error code in module_job
devsnek Jun 15, 2018
4970e2b
doc: eliminate _you_ from N-API doc
Trott Jun 18, 2018
8944a4f
test: move test-benchmark-path to sequential
Trott Jun 18, 2018
7ae718c
module: optimize require performance
mapleeit Jun 12, 2018
a8b24b6
module: fix bug when parent is null
mapleeit Jun 12, 2018
b5cbf39
module: fix require.resolve case
mapleeit Jun 13, 2018
4454a01
module: use internal cache instead of public one
mapleeit Jun 19, 2018
de6af7c
module: resolve conficts
mapleeit Jun 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
perf_hooks: set bootstrap complete in only one place 
PR-URL: #21247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
  • Loading branch information
@jasnell
jasnell committed Jun 15, 2018
commit 17e378b51a4e35533b43bae66e7aa76faaad17b3
10 changes: 2 additions & 8 deletions lib/internal/bootstrap/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,8 @@
}
}

perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);

// There are various modes that Node can run in. The most common two
// are running from a script and running the REPL - but there are a few
// others like the debugger or running --eval arguments. Here we decide
Expand All @@ -186,7 +188,6 @@
// To allow people to extend Node in different ways, this hook allows
// one to drop a file lib/_third_party_main.js into the build
// directory which will be executed instead of Node's normal loading.
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
process.nextTick(function() {
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_THIRD_PARTY_MAIN_START);
NativeModule.require('_third_party_main');
Expand All @@ -200,13 +201,11 @@
}

// Start the debugger agent.
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
process.nextTick(function() {
NativeModule.require('internal/deps/node-inspect/lib/_inspect').start();
});

} else if (process.profProcess) {
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
NativeModule.require('internal/v8_prof_processor');
} else {
// There is user code to be run.
Expand Down Expand Up @@ -238,7 +237,6 @@
addBuiltinLibsToObject
} = NativeModule.require('internal/modules/cjs/helpers');
addBuiltinLibsToObject(global);
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
evalScript('[eval]');
} else if (process.argv[1] && process.argv[1] !== '-') {
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_MODULE_LOAD_START);
Expand All @@ -263,7 +261,6 @@
checkScriptSyntax(source, filename);
process.exit(0);
}
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
CJSModule.runMain();
} else {
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_MODULE_LOAD_START);
Expand Down Expand Up @@ -294,7 +291,6 @@

if (process._eval != null) {
// User passed '-e' or '--eval'
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
evalScript('[eval]');
}
} else {
Expand All @@ -311,14 +307,12 @@
checkScriptSyntax(code, '[stdin]');
} else {
process._eval = code;
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
evalScript('[stdin]');
}
});
}
}
}
perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
}

function setupProcessObject() {
Expand Down