Skip to content

Test stream writable state #21292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deleteman wants to merge 3 commits into from
Closed

Test stream writable state #21292

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f84c51
Improved test for streamState by removing uneeded error string
deleteman Jun 12, 2018
9fad50b
test: remove string error from strictEquals
deleteman Jun 12, 2018
eb2547f
test: remove comment added in previous commit
deleteman Jun 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: remove string error from strictEquals 
Removes the string error from the assertion call to
improve the error message shown on screen when the
test fails.
  • Loading branch information
@deleteman
deleteman committed Jun 12, 2018
commit 9fad50bb1cf05c19f4b103dcd7be7c3116f270ac
2 changes: 1 addition & 1 deletion test/parallel/test-stream-writableState-uncorked-bufferedRequestCount.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const stream = require('stream');
const writable = new stream.Writable();

writable._writev = common.mustCall((chunks, cb) => {
//two chunks to write
//error: two chunks to write
Copy link
Copy Markdown
Member

@lpinca lpinca Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment can be removed. Maybe it's just me but I don't find it useful.

Copy link
Copy Markdown
Contributor

@apapirovski apapirovski Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. This will also fail our linter due to the lack of a space after //.

Copy link
Copy Markdown
Contributor Author

@deleteman deleteman Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello both, thanks for the comments, I've added a new commit to this PR to remove the comment.

Let me know what you think.

Cheers

assert.strictEqual(chunks.length, 2);
cb();
}, 1);
Expand Down