Skip to content

win, build: generate .sln only when necessary #21284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzoz wants to merge 6 commits into from
Closed

win, build: generate .sln only when necessary #21284

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f47cb20
win, build: generate .sln only when necessary
bzoz Jun 7, 2018
db9dc09
fixups
bzoz Jun 13, 2018
1838d2b
fixup
bzoz Jun 13, 2018
7e1f3eb
fixup
bzoz Jun 13, 2018
88ab8e8
Add warning message after compilation fails
bzoz Jun 14, 2018
6ec5ede
Rebuild project files if gyp files where modified
bzoz Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add warning message after compilation fails
  • Loading branch information
@bzoz
bzoz committed Jun 14, 2018
commit 88ab8e8a55439a97d82b0e12caa72f694a80dd7f
7 changes: 6 additions & 1 deletion vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ goto build-doc

:msbuild-found

set project_generated=
:project-gen
@rem Skip project generation if requested.
if defined noprojgen goto skip-configure
Expand All @@ -275,6 +276,7 @@ echo %configure_flags%> .used_configure_flags
python configure %configure_flags%
if errorlevel 1 goto create-msvs-files-failed
if not exist node.sln goto create-msvs-files-failed
set project_generated=1
echo Project files generated.

:msbuild
Expand All @@ -288,7 +290,10 @@ set "msbplatform=Win32"
if "%target_arch%"=="x64" set "msbplatform=x64"
if "%target%"=="Build" if defined no_cctest set target=node
msbuild node.sln %msbcpu% /t:%target% /p:Configuration=%config% /p:Platform=%msbplatform% /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo
if errorlevel 1 goto exit
if errorlevel 1 (
if not defined project_generated echo Building Node with reused solution failed. To regenerate project files use "vcbuild projgen"
goto exit
)
if "%target%" == "Clean" goto exit

:sign
Expand Down