Skip to content

build: don't change locale on smartos #21220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 2 commits into from
Closed

build: don't change locale on smartos #21220

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
447efae
build: don't change locale on smartos
refack Jun 8, 2018
ed844ce
fixup! add reasoning
refack Jun 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! add reasoning
  • Loading branch information
@refack
refack authored Jun 8, 2018
commit ed844ceb946c6cb407497422db3f795173381ef6
2 changes: 2 additions & 0 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,8 @@ def get_xcode_version(cc):
def get_gas_version(cc):
try:
custom_env = os.environ.copy()
# smartos (a.k.a. sunos5) does not have the en_US locale, and will give:
# `setlocale: LC_ALL: cannot change locale (en_US): Invalid argument`
if 'sunos' not in sys.platform:
custom_env["LC_ALL"] = "en_US"
Copy link
Copy Markdown
Member

@addaleax addaleax Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining why smartos is excluded?

proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o',
Expand Down