Skip to content

http: fix request with option timeout and agent #21204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
killagu wants to merge 7 commits into from
Closed

http: fix request with option timeout and agent #21204

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
33e62a1
http: fix request with option timeout and agent
killagu Jun 8, 2018
4add8f6
update tests
killagu Jun 11, 2018
7ab62fb
minor edit to doc text
Trott Jun 11, 2018
9773531
fixup! minor edit to comment text
Trott Jun 11, 2018
3b30906
squash! minor edit to comment
Trott Jun 11, 2018
1cf617e
squash! minor edits to comments
Trott Jun 11, 2018
2c5f0c0
squash! minor edits to comments
Trott Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash! minor edit to comment
  • Loading branch information
@Trott
Trott authored Jun 11, 2018
commit 3b30906dc043f7cb4ece8344630ce2528cf6c5bc
3 changes: 1 addition & 2 deletions test/parallel/test-http-client-set-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
'use strict';
const common = require('../common');

// The test ensure call `req.setTimeout` will not let
// timeout fired twice.
// Test that `req.setTimeout` will fired exactly once.

const assert = require('assert');
const http = require('http');
Expand Down