Skip to content

[v10.x] Backport pending pull requests #21172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 14 commits into from
Closed

[v10.x] Backport pending pull requests #21172

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0577312
fs: don't limit ftruncate() length to 32 bits
cjihrig May 20, 2018
39df351
process: backport process/methods file
targos Jun 6, 2018
748ca53
lib: mask mode_t type of arguments with 0o777
joyeecheung May 9, 2018
57a11af
doc: document file mode caveats on Windows
joyeecheung May 9, 2018
f6ab989
fs: drop duplicate API in promises mode
ChALkeR May 6, 2018
436cf2d
lib: support ranges in validateInt32()
cjihrig May 20, 2018
c6e9e54
fs: improve fchmod{Sync} validation
cjihrig May 20, 2018
b50c42e
fs: refactor fs module
jasnell May 15, 2018
f4287e6
test: increase coverage for fs.promises.truncate
May 9, 2018
c13cd35
src: refactor bootstrap to use bootstrap object
jasnell May 23, 2018
1bdc06b
doc: fix inconsistent documentation (host vs hostname)
davisokoth May 24, 2018
633b24d
lib: unmask mode_t values with 0o777
joyeecheung May 26, 2018
d2ad241
fs: do not crash when using a closed fs event watcher
joyeecheung May 26, 2018
a20498a
async_hooks: remove deprecated example
mafintosh May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: increase coverage for fs.promises.truncate 
To increase test coverage, added tests for fs.promises.truncate
and FileHandle.truncate.

PR-URL: #20638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@targos
Masashi Hirano authored and targos committed Jun 6, 2018
commit f4287e61d71098e858a5d389feabac476ad6a51e
26 changes: 26 additions & 0 deletions test/parallel/test-fs-promises-file-handle-truncate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
'use strict';

const common = require('../common');
const assert = require('assert');
const path = require('path');
const { open, readFile } = require('fs').promises;
const tmpdir = require('../common/tmpdir');

tmpdir.refresh();
common.crashOnUnhandledRejection();

async function validateTruncate() {
const text = 'Hello world';
const filename = path.resolve(tmpdir.path, 'truncate-file.txt');
const fileHandle = await open(filename, 'w+');

const buffer = Buffer.from(text, 'utf8');
await fileHandle.write(buffer, 0, buffer.length);

assert.deepStrictEqual((await readFile(filename)).toString(), text);

await fileHandle.truncate(5);
assert.deepStrictEqual((await readFile(filename)).toString(), 'Hello');
}

validateTruncate().then(common.mustCall());
4 changes: 4 additions & 0 deletions test/parallel/test-fs-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ const {
mkdir,
mkdtemp,
open,
readFile,
readdir,
readlink,
realpath,
rename,
rmdir,
stat,
symlink,
truncate,
unlink,
utimes
} = fsPromises;
Expand Down Expand Up @@ -99,6 +101,8 @@ function verifyStatObject(stat) {
const ret2 = await handle.read(Buffer.alloc(buf2Len), 0, buf2Len, 0);
assert.strictEqual(ret2.bytesRead, buf2Len);
assert.deepStrictEqual(ret2.buffer, buf2);
await truncate(dest, 5);
assert.deepStrictEqual((await readFile(dest)).toString(), 'hello');

await chmod(dest, 0o666);
await handle.chmod(0o666);
Expand Down