Skip to content

test: apply promises API to appendFile test #21131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

test: apply promises API to appendFile test #21131

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a281c60
test: apply promises API to third appendFile test
Trott Jun 4, 2018
fef804a
test: apply promises API to fourth appendFile test
Trott Jun 4, 2018
82da112
test: apply promises API to fourth appendFile test
Trott Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: apply promises API to fourth appendFile test 
Add tests for `fs.promises.appendFile()` to the fourth (of five) test
case in `test-fs-access`. (The previous test cases already have
promises API versions.)
  • Loading branch information
@Trott
Trott committed Jun 4, 2018
commit fef804af641ad8c7cff69b2572f92d8f42584f0f
63 changes: 42 additions & 21 deletions test/parallel/test-fs-append-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,29 +132,51 @@ const throwNextTick = (e) => { process.nextTick(() => { throw e; }); };
.catch(throwNextTick);
}

// test that appendFile accepts numbers.
const filename4 = join(tmpdir.path, 'append4.txt');
fs.writeFileSync(filename4, currentFileData);
// test that appendFile accepts numbers (callback API)
{
const filename = join(tmpdir.path, 'append-numbers.txt');
fs.writeFileSync(filename, currentFileData);

const m = 0o600;
fs.appendFile(filename4, n, { mode: m }, function(e) {
assert.ifError(e);
const m = 0o600;
fs.appendFile(filename, n, { mode: m }, common.mustCall((e) => {
assert.ifError(e);

ncallbacks++;
// windows permissions aren't unix
if (!common.isWindows) {
const st = fs.statSync(filename);
assert.strictEqual(st.mode & 0o700, m);
}

// windows permissions aren't unix
if (!common.isWindows) {
const st = fs.statSync(filename4);
assert.strictEqual(st.mode & 0o700, m);
}
fs.readFile(filename, common.mustCall((e, buffer) => {
assert.ifError(e);
assert.strictEqual(Buffer.byteLength(String(n)) + currentFileData.length,
buffer.length);
}));
}));
}

fs.readFile(filename4, function(e, buffer) {
assert.ifError(e);
ncallbacks++;
assert.strictEqual(Buffer.byteLength(String(n)) + currentFileData.length,
buffer.length);
});
});
// test that appendFile accepts numbers (promises API)
{
const filename = join(tmpdir.path, 'append-numbers-promises.txt');
fs.writeFileSync(filename, currentFileData);

const m = 0o600;
fs.promises.appendFile(filename, n, { mode: m })
.then(common.mustCall(() => {
// windows permissions aren't unix
if (!common.isWindows) {
const st = fs.statSync(filename);
assert.strictEqual(st.mode & 0o700, m);
}

return fs.promises.readFile(filename);
}))
.then((buffer) => {
assert.strictEqual(Buffer.byteLength(String(n)) + currentFileData.length,
buffer.length);
})
.catch(throwNextTick);
}

// test that appendFile accepts file descriptors
const filename5 = join(tmpdir.path, 'append5.txt');
Expand Down Expand Up @@ -191,8 +213,7 @@ assert.throws(
{ code: 'ERR_INVALID_CALLBACK' });

process.on('exit', function() {
assert.strictEqual(ncallbacks, 6);
assert.strictEqual(ncallbacks, 4);

fs.unlinkSync(filename4);
fs.unlinkSync(filename5);
});