Skip to content

deps: update V8 to 6.8 #21079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 18 commits into from
Closed

deps: update V8 to 6.8 #21079

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c4df717
deps: update V8 to 6.8.275.24
targos Jul 25, 2018
c05eb76
build: reset embedder string to "-node.0"
targos Jul 25, 2018
3e612e1
src: update NODE_MODULE_VERSION to 65
targos Jul 25, 2018
85006ec
deps: update v8.gyp and run Torque
targos Apr 19, 2018
3507a56
deps: cherry-pick 5dd3395 from upstream V8
Jun 18, 2018
e320bd5
deps: cherry-pick aa6ce3e from upstream V8
targos Jul 5, 2018
742f9ea
deps: cherry-pick b20faff from upstream V8
Jun 11, 2018
06c0358
deps: cherry-pick acc336c from upstream V8
Jun 18, 2018
e39f302
deps: cherry-pick 70c4340 from upstream V8
Jun 21, 2018
5069b2b
deps: cherry-pick 477df06 from upstream v8
devsnek Jul 3, 2018
f28be41
deps: cherry-pick 555c811 from upstream V8
addaleax Jun 30, 2018
e7ece11
deps: cherry-pick 2075910 from upstream V8
targos Jul 16, 2018
b30114c
deps: cherry-pick 907d7bc from upstream V8
targos Jul 16, 2018
0d71635
deps: V8: Backport of 0dd3390 from upstream
jasnell Jul 19, 2018
ce8ba87
deps: cherry-pick 804a693 from upstream V8
Jul 17, 2018
ee334a1
test: fix scriptParsed event expectations
RReverser Apr 17, 2018
fd80317
test: update postmortem metadata test
cjihrig May 6, 2018
befa6b9
src: use modern v8::Platform worker threads APIs
May 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix scriptParsed event expectations 
As per Node.js docs, vm.Script instance is not bound to any context.

However, this test was expecting otherwise and depended on
implementation details which are going to change.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1013581
  • Loading branch information
@RReverser @targos
RReverser authored and targos committed Jul 25, 2018
commit ee334a1d9518fb08e87bb071cd41da3ebf774767
34 changes: 7 additions & 27 deletions test/sequential/test-inspector-scriptparsed-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,17 @@ const script = `
'use strict';
const assert = require('assert');
const vm = require('vm');
const { kParsingContext } = process.binding('contextify');
global.outer = true;
global.inner = false;
const context = vm.createContext({
outer: false,
inner: true
});
const script = new vm.Script("outer");
debugger;

const scriptMain = new vm.Script("outer");
debugger;

const scriptContext = new vm.Script("inner", {
[kParsingContext]: context
});
debugger;

assert.strictEqual(scriptMain.runInThisContext(), true);
assert.strictEqual(scriptMain.runInContext(context), false);
assert.strictEqual(scriptContext.runInThisContext(), false);
assert.strictEqual(scriptContext.runInContext(context), true);
assert.strictEqual(script.runInThisContext(), true);
assert.strictEqual(script.runInContext(context), false);
debugger;

vm.runInContext('inner', context);
Expand Down Expand Up @@ -64,35 +54,25 @@ async function runTests() {
await session.waitForBreakOnLine(0, '[eval]');

await session.send({ 'method': 'Runtime.enable' });
const topContext = await getContext(session);
await getContext(session);
await session.send({ 'method': 'Debugger.resume' });
const childContext = await getContext(session);
await session.waitForBreakOnLine(13, '[eval]');

console.error('[test]', 'Script associated with current context by default');
await session.send({ 'method': 'Debugger.resume' });
await checkScriptContext(session, topContext);
await session.waitForBreakOnLine(16, '[eval]');

console.error('[test]', 'Script associated with selected context');
await session.send({ 'method': 'Debugger.resume' });
await checkScriptContext(session, childContext);
await session.waitForBreakOnLine(21, '[eval]');

console.error('[test]', 'Script is unbound');
await session.send({ 'method': 'Debugger.resume' });
await session.waitForBreakOnLine(27, '[eval]');
await session.waitForBreakOnLine(17, '[eval]');

console.error('[test]', 'vm.runInContext associates script with context');
await session.send({ 'method': 'Debugger.resume' });
await checkScriptContext(session, childContext);
await session.waitForBreakOnLine(30, '[eval]');
await session.waitForBreakOnLine(20, '[eval]');

console.error('[test]', 'vm.runInNewContext associates script with context');
await session.send({ 'method': 'Debugger.resume' });
const thirdContext = await getContext(session);
await checkScriptContext(session, thirdContext);
await session.waitForBreakOnLine(33, '[eval]');
await session.waitForBreakOnLine(23, '[eval]');

console.error('[test]', 'vm.runInNewContext can contain debugger statements');
await session.send({ 'method': 'Debugger.resume' });
Expand Down