Skip to content

reduce ESLint exceptions in benchmarks #21030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 8 commits into from
Closed

reduce ESLint exceptions in benchmarks #21030

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
60a24f5
benchmark: refactor deepequal-buffer
Trott May 30, 2018
cacb155
benchmark: refactor deepequal-map
Trott May 30, 2018
e76f5c1
benchmark: refactor deepequal-object
Trott May 30, 2018
b728cf5
benchmark: refactor prims-and-objs-big-array-set
Trott May 30, 2018
19189fb
benchmark: refactor prims-and-objs-big-loop
Trott May 30, 2018
05c542c
benchmark: refactor deepequal-set
Trott May 30, 2018
0bc8145
benchmark: refactor deepequal-typedarrays
Trott May 30, 2018
ab97403
benchmark: refactor benchmark/assert/throws.js
Trott May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark: refactor deepequal-typedarrays 
This is a minor refactor of benchmark/assert/deepequal-typedarrays.js to
reduce exceptions that need to be made for lint compliance.
  • Loading branch information
@Trott
Trott committed May 30, 2018
commit 0bc8145f8efb373fbfa92e1543faa34d0a831762
5 changes: 3 additions & 2 deletions benchmark/assert/deepequal-typedarrays.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,16 @@ const bench = common.createBenchmark(main, {
});

function main({ type, n, len, method }) {
if (!method)
method = 'deepEqual';
const clazz = global[type];
const actual = new clazz(len);
const expected = new clazz(len);
const expectedWrong = Buffer.alloc(len);
const wrongIndex = Math.floor(len / 2);
expectedWrong[wrongIndex] = 123;

// eslint-disable-next-line no-restricted-properties
const fn = method !== '' ? assert[method] : assert.deepEqual;
const fn = assert[method];
const value2 = method.includes('not') ? expectedWrong : expected;

bench.start();
Expand Down