Skip to content

tools: ensure doc-only doesn't update package-lock #21015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 1 commit into from
Closed

tools: ensure doc-only doesn't update package-lock #21015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: ensure doc-only doesn't update package-lock 
Currently `make doc-only` is updating the package-lock.json
which is breaking our release build.

This adds the flags `--no-package-lock` when
running `npm install` to ensure the package-lock.json is not
changed unintentionally by running make
  • Loading branch information
@MylesBorins
MylesBorins committed Jun 6, 2018
commit 9ed2f01ec0e63993a7389bab8b5379608420b468
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ available-node = \
exit 1; \
fi;

run-npm-install = $(PWD)/$(NPM) install --production
run-npm-install = $(PWD)/$(NPM) install --production --no-package-lock

tools/doc/node_modules/js-yaml/package.json:
cd tools/doc && $(call available-node,$(run-npm-install))
Expand Down