Skip to content

test: mark test-fs-readfile-tostring-fail as flaky #21013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 2 commits into from
Closed

test: mark test-fs-readfile-tostring-fail as flaky #21013

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5cf2da
test: mark test-fs-readfile-tostring-fail as flaky
May 29, 2018
5e1b4af
fixup! test: mark test-fs-readfile-tostring-fail as flaky
May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: mark test-fs-readfile-tostring-fail as flaky 
test-fs-readfile-tostring-fail is failing frequently on OSX machines.
There's a PR to fix this issue in libuv, but while the fix don't land on
Node.js this test should be marked as flaky.

Ref: #16601
Ref: libuv/libuv#1742
  • Loading branch information
Matheus Marchini committed May 29, 2018
commit e5cf2dac094d00994a5861f83300697aea3fdc59
1 change: 1 addition & 0 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ test-inspector-async-hook-setup-at-signal: PASS, FLAKY
[$system==linux]

[$system==macos]
test-fs-readfile-tostring-fail: PASS, FLAKY

[$system==solaris] # Also applies to SmartOS

Expand Down