Skip to content

test: improve path tests #20967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Shivang44 wants to merge 1 commit into from
Closed

test: improve path tests #20967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: improve path tests 
Replaced deepStrictEqual with strictEqual when asserting that the
path is equal to the win32 or posix equivalent, since it is a more
strict check than deepStrictCheck. Also removed third argument
in the check so that if there is an assertion error the properties
that are different will be displayed.
  • Loading branch information
@Shivang44
Shivang44 committed May 25, 2018
commit cff75afff6483482c11561c09ccea2349c2b181b
4 changes: 2 additions & 2 deletions test/parallel/test-path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@ assert.strictEqual(path.win32.delimiter, ';');
assert.strictEqual(path.posix.delimiter, ':');

if (common.isWindows)
assert.deepStrictEqual(path, path.win32, 'should be win32 path module');
assert.strictEqual(path, path.win32);
else
assert.deepStrictEqual(path, path.posix, 'should be posix path module');
assert.strictEqual(path, path.posix);