Skip to content

src: begin restructuring node.cc for better maintainability #20789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

src: begin restructuring node.cc for better maintainability #20789

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dbbad6
src: move CallbackScope to separate cc/h
jasnell May 16, 2018
8a7f1c1
src: fix odd linting issue
jasnell May 16, 2018
6788dec
src: move *Exceptions out to separate cc/h
jasnell May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: fix odd linting issue 
The prior commit causes a linting issue here.
Fix by changing from a struct to a class.
  • Loading branch information
@jasnell
jasnell committed May 16, 2018
commit 8a7f1c170deaa1942193f15e8c898355d0afbdc7
5 changes: 3 additions & 2 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2063,7 +2063,8 @@ node_module* get_linked_module(const char* name) {
return FindModule(modlist_linked, name, NM_F_LINKED);
}

struct DLib {
class DLib {
public:
#ifdef __POSIX__
static const int kDefaultFlags = RTLD_LAZY;
#else
Expand All @@ -2084,7 +2085,7 @@ struct DLib {
#ifndef __POSIX__
uv_lib_t lib_;
#endif

private:
DISALLOW_COPY_AND_ASSIGN(DLib);
};

Expand Down