Skip to content

test: plug AliasedBuffer cctest memory leak #20665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

test: plug AliasedBuffer cctest memory leak #20665

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
465d9f2
test: plug AliasedBuffer cctest memory leak
addaleax May 10, 2018
12b631b
[squash] switch to std::vector
addaleax May 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: plug AliasedBuffer cctest memory leak 
No need to heap-allocate values here.
  • Loading branch information
@addaleax
addaleax committed May 10, 2018
commit 465d9f27854c372c4cd2e630bb02561a24a5644f
6 changes: 3 additions & 3 deletions test/cctest/test_aliased_buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ void SharedBufferTest(
AliasedBuffer<NativeT_C, V8T_C> ab_C(
isolate, sizeInBytes_A + sizeInBytes_B, count_C, rootBuffer);

NativeT_A* oracle_A = new NativeT_A[count_A];
NativeT_B* oracle_B = new NativeT_B[count_B];
NativeT_C* oracle_C = new NativeT_C[count_C];
NativeT_A oracle_A[count_A];
NativeT_B oracle_B[count_B];
NativeT_C oracle_C[count_C];
CreateOracleValues(oracle_A, count_A);
CreateOracleValues(oracle_B, count_B);
CreateOracleValues(oracle_C, count_C);
Expand Down