Skip to content

lib: mask mode_t type of arguments with 0o777 #20636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

lib: mask mode_t type of arguments with 0o777 #20636

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
853aac2
lib: mask mode_t type of arguments with 0o777
joyeecheung May 9, 2018
6fa590b
doc: document file mode caveats on Windows
joyeecheung May 9, 2018
37af759
fixup! lib: mask mode_t type of arguments with 0o777
joyeecheung May 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! lib: mask mode_t type of arguments with 0o777
  • Loading branch information
@joyeecheung
joyeecheung committed May 17, 2018
commit 37af759be77bb70a6c8e8c861318c2c0a182fbfb
26 changes: 4 additions & 22 deletions test/parallel/test-fs-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,28 +113,10 @@ function verifyStatObject(stat) {
await fchmod(handle, 0o666);
await handle.chmod(0o666);

// `mode` can't be > 0o777
assert.rejects(
async () => chmod(handle, (0o777 + 1)),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError [ERR_INVALID_ARG_TYPE]'
}
);
assert.rejects(
async () => fchmod(handle, (0o777 + 1)),
{
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError [ERR_OUT_OF_RANGE]'
}
);
assert.rejects(
async () => handle.chmod(handle, (0o777 + 1)),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError [ERR_INVALID_ARG_TYPE]'
}
);
// Mode larger than 0o777 should be masked off.
await chmod(dest, (0o777 + 1));
await fchmod(handle, 0o777 + 1);
await handle.chmod(0o777 + 1);

await utimes(dest, new Date(), new Date());

Expand Down