Skip to content

util: limit util inspect depth to 10 #20627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 3 commits into from
Closed

util: limit util inspect depth to 10 #20627

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37c27ef
util: change depth default to 10
BridgeAR May 7, 2018
eec6468
test: add regression test for inspect depth
addaleax May 6, 2018
e58cde1
util: limit depth to 1000
BridgeAR May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add regression test for inspect depth 
Make sure that a long singly-linked list can be passed
to `util.inspect()` without causing a stack overflow.
  • Loading branch information
@addaleax @BridgeAR
addaleax authored and BridgeAR committed May 9, 2018
commit eec6468cfe428744f169b17149fb3ce05d3c2763
12 changes: 12 additions & 0 deletions test/parallel/test-util-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,3 +1404,15 @@ util.inspect(process);
const args = (function() { return arguments; })('a');
assert.strictEqual(util.inspect(args), "[Arguments] { '0': 'a' }");
}

{
// Test that a long linked list can be inspected without throwing an error.
const list = {};
let head = list;
// The real cutoff value is closer to 1400 stack frames as of May 2018,
// but let's be generous here – even a linked listed of length 100k should be
// inspectable in some way.
for (let i = 0; i < 100000; i++)
head = head.next = {};
util.inspect(list);
}