Skip to content

repl: add hint as to how to exit #20617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
monkingxue wants to merge 5 commits into from
Closed

repl: add hint as to how to exit #20617

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b88a82
repl: add friendly tips about how to exit repl
monkingxue May 9, 2018
17e1272
style: fix the code style
monkingxue May 10, 2018
51282ef
fix: duplication of command name and variable name
monkingxue May 10, 2018
93c1647
fix: move the check of variables' name to before the command run
monkingxue May 11, 2018
de3385a
style
monkingxue May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: duplication of command name and variable name 
Before output the hint, check if defined
the command-named variable as an error
  • Loading branch information
@monkingxue
monkingxue committed May 18, 2018
commit 51282ef33eca2ba0c8bdbcaa798ffc9dd0b8dead
3 changes: 2 additions & 1 deletion lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,8 @@ function REPLServer(prompt,
}
}
} catch (e) {
if (isExitCommand) {
const context = this.useGlobal ? global : this.context;
if (isExitCommand && !context.hasOwnProperty(trimCommand)) {
Copy link
Copy Markdown
Contributor

@princejwesley princejwesley May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be done before executing the code, right?

Copy link
Copy Markdown
Contributor Author

@monkingxue monkingxue May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean define the context out of the catch block ?

Copy link
Copy Markdown
Contributor

@princejwesley princejwesley May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. the whole test condition. check this before executing vm.runInContext

Copy link
Copy Markdown
Contributor Author

@monkingxue monkingxue May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I got it and I have modified the code, thank u~

self.outputStream.write('(To exit, press ^D or type .exit)\n');
return self.displayPrompt();
}
Expand Down