Skip to content

tools: use macOS as operating system name #20579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

tools: use macOS as operating system name #20579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: use macOS as operating system name 
As of 2016, the operating system is macOS. Remove use of "macosx".
  • Loading branch information
@Trott
Trott committed May 7, 2018
commit ca898266260928fdcaccbb49852c4273e89eaffd
4 changes: 2 additions & 2 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,15 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and
If the path to your build directory contains a space, the build will likely
fail.

After building, setting up [firewall rules](tools/macosx-firewall.sh) can avoid
After building, setting up [firewall rules](tools/macos-firewall.sh) can avoid
popups asking to accept incoming network connections when running tests.

Running the following script on macOS will add the firewall rules for the
executable `node` in the `out` directory and the symbolic `node` link in the
project's root directory.

```console
$ sudo ./tools/macosx-firewall.sh
$ sudo ./tools/macos-firewall.sh
```

On FreeBSD and OpenBSD, you may also need:
Expand Down
0 tools/macosx-firewall.sh → tools/macos-firewall.sh
View file
Open in desktop
File renamed without changes.