Skip to content

url: fix WHATWG URL host formatting error caused by port string #20493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peakji wants to merge 4 commits into from
Closed

url: fix WHATWG URL host formatting error caused by port string #20493

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6135fca
url: fix WHATWG host formatting error
peakji May 3, 2018
450272c
test: format WHATWG URL with port
peakji May 3, 2018
75f3f68
url: fix the missing semicolon
peakji May 3, 2018
3db8aac
url: fix WHATWG formatting logic
peakji May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
url: fix WHATWG formatting logic
  • Loading branch information
@peakji
peakji authored May 3, 2018
commit 3db8aacfb1c49adfc36eb52a9503b4b60dc34ec6
4 changes: 2 additions & 2 deletions lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ Object.defineProperties(URL.prototype, {
}, options);
const ctx = this[context];
var ret = ctx.scheme;
if (ctx.hostname !== null) {
if (ctx.host !== null) {
ret += '//';
const has_username = ctx.username !== '';
const has_password = ctx.password !== '';
Expand All @@ -401,7 +401,7 @@ Object.defineProperties(URL.prototype, {
}
ret += options.unicode ?
domainToUnicode(this.hostname) : this.hostname;
if (ctx.port !== '')
if (ctx.port !== null)
ret += `:${ctx.port}`;
} else if (ctx.scheme === 'file:') {
ret += '//';
Expand Down