Skip to content

brotli: add brotli support #20458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hackzzila wants to merge 11 commits into from
Closed

brotli: add brotli support #20458

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a295f2a
deps: add brotli
Hackzzila May 1, 2018
5d82880
brotli: add brotli
Hackzzila May 1, 2018
52e2070
benchmark,test: add brotli
Hackzzila May 1, 2018
2154080
doc, test: add brotli and fix tests
Hackzzila May 1, 2018
54aa2e7
doc: improve brotli docs
Hackzzila May 2, 2018
69cc504
doc: make acceptEncoding const
Hackzzila May 2, 2018
5eb194f
doc: small brotli doc fixes
Hackzzila May 2, 2018
72c2d4e
doc: small doc fixes
Hackzzila May 2, 2018
be82db1
brotli,doc,src,test: remove copyright headers, small doc/code fixes
Hackzzila May 2, 2018
ccc89f2
deps,tools: update license-builder.sh and LICENSE
Hackzzila May 2, 2018
fcae0ef
Merge branch 'master' into brotli-dev
Hackzzila Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: small doc fixes
  • Loading branch information
@Hackzzila
Hackzzila committed May 2, 2018
commit 72c2d4e864ad70286a3a9ef1a2e9404113e71065
6 changes: 3 additions & 3 deletions doc/api/brotli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,12 @@ http.createServer((request, response) => {
const raw = fs.createReadStream('index.html');
const acceptEncoding = request.headers['accept-encoding'] || '';

// Note: This is not a conformant accept-encoding parser.
// This is not a conformant accept-encoding parser.
// See https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.3
if (/\bbr\b/.test(acceptEncoding)) {
response.writeHead(200, { 'Content-Encoding': 'br' });

// Note: A quality of 4 is a good balance of speed and quality.
// A quality of 4 is a good balance of speed and quality.
// See https://blogs.akamai.com/2016/02/understanding-brotlis-potential.html
raw.pipe(new brotli.Compress({ quality: 4 })).pipe(response);
} else {
Expand Down Expand Up @@ -266,7 +266,7 @@ added: REPLACEME
Each class takes an `options` object. All options are optional.

Note that some options are only relevant when compressing or decompressing,
and are simply ignored.
and invalid options are simply ignored.

* `chunkSize` {integer}
**Default:** `16 * 1024`
Expand Down