Skip to content

events: optimize condition for optimal scenario #20452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apapirovski wants to merge 2 commits into from
Closed

events: optimize condition for optimal scenario #20452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
282749f
events: optimize condition for optimal scenario
apapirovski May 1, 2018
71a1aa1
fixup: simplify conditional further
apapirovski May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: simplify conditional further
  • Loading branch information
@apapirovski
apapirovski committed May 2, 2018
commit 71a1aa1b9021b20e98305143afaf034d6e76171c
2 changes: 1 addition & 1 deletion lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ function _addListener(target, type, listener, prepend) {

// Check for listener leak
m = $getMaxListeners(target);
if (m && m > 0 && existing.length > m && !existing.warned) {
if (m > 0 && existing.length > m && !existing.warned) {
existing.warned = true;
// No error code for this since it is a Warning
// eslint-disable-next-line no-restricted-syntax
Expand Down