Skip to content

src: fix inconsistency in extern declaration #20436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hashseed wants to merge 1 commit into from
Closed

src: fix inconsistency in extern declaration #20436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: fix inconsistency in extern declaration 
NodeCounterProvider is declared as extern but defined as EXTERN_C.
This confuses clang-cl.
  • Loading branch information
@hashseed
hashseed committed Apr 30, 2018
commit 3b8e9288e37518b4f9ae6f48b762e4cd0d011def
2 changes: 1 addition & 1 deletion src/node_win32_perfctr_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ PPERF_COUNTERSET_INSTANCE perfctr_instance;
namespace node {


EXTERN_C DECLSPEC_SELECTANY HANDLE NodeCounterProvider = nullptr;
HANDLE NodeCounterProvider = nullptr;

void InitPerfCountersWin32() {
ULONG status;
Expand Down