Skip to content

http2: rename http2_state class to Http2State #20423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 2 commits into from
Closed

http2: rename http2_state class to Http2State #20423

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e7dbe0
http2: rename http2_state class to Http2State
danbev Apr 30, 2018
230cf8a
doc: add snake_case section for C-like structs
danbev May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http2: rename http2_state class to Http2State 
This commit renames the http2_state class to follow the guidelines in
CPP_STYLE_GUIDE.md.
  • Loading branch information
@danbev
danbev committed Apr 30, 2018
commit 6e7dbe052a74dee2f797ba7e54b5e635b75258d4
4 changes: 2 additions & 2 deletions src/env-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,12 +482,12 @@ inline void Environment::set_http_parser_buffer_in_use(bool in_use) {
http_parser_buffer_in_use_ = in_use;
}

inline http2::http2_state* Environment::http2_state() const {
inline http2::Http2State* Environment::http2_state() const {
return http2_state_.get();
}

inline void Environment::set_http2_state(
std::unique_ptr<http2::http2_state> buffer) {
std::unique_ptr<http2::Http2State> buffer) {
CHECK(!http2_state_); // Should be set only once.
http2_state_ = std::move(buffer);
}
Expand Down
6 changes: 3 additions & 3 deletions src/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,8 +643,8 @@ class Environment {
inline bool http_parser_buffer_in_use() const;
inline void set_http_parser_buffer_in_use(bool in_use);

inline http2::http2_state* http2_state() const;
inline void set_http2_state(std::unique_ptr<http2::http2_state> state);
inline http2::Http2State* http2_state() const;
inline void set_http2_state(std::unique_ptr<http2::Http2State> state);

inline AliasedBuffer<double, v8::Float64Array>* fs_stats_field_array();

Expand Down Expand Up @@ -829,7 +829,7 @@ class Environment {

char* http_parser_buffer_;
bool http_parser_buffer_in_use_ = false;
std::unique_ptr<http2::http2_state> http2_state_;
std::unique_ptr<http2::Http2State> http2_state_;

AliasedBuffer<double, v8::Float64Array> fs_stats_field_array_;

Expand Down
2 changes: 1 addition & 1 deletion src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2660,7 +2660,7 @@ void Initialize(Local<Object> target,
Isolate* isolate = env->isolate();
HandleScope scope(isolate);

std::unique_ptr<http2_state> state(new http2_state(isolate));
std::unique_ptr<Http2State> state(new Http2State(isolate));

#define SET_STATE_TYPEDARRAY(name, field) \
target->Set(context, \
Expand Down
4 changes: 2 additions & 2 deletions src/node_http2_state.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ namespace http2 {
IDX_SESSION_STATS_COUNT
};

class http2_state {
class Http2State {
public:
explicit http2_state(v8::Isolate* isolate) :
explicit Http2State(v8::Isolate* isolate) :
root_buffer(
isolate,
sizeof(http2_state_internal)),
Expand Down