Skip to content

tools: dedupe property access in doc/type-parser #20387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsemozhetbyt wants to merge 1 commit into from
Closed

tools: dedupe property access in doc/type-parser #20387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: dedupe property access in doc/type-parser 
There is no need to get this property twice in this rather hot spot:
if there is no such key, the `typeUrl` will be `undefined`,
which suffices for the boolean check in the next line.

For consistency, `undefined` can also be made the default value.
  • Loading branch information
@vsemozhetbyt
vsemozhetbyt committed Apr 29, 2018
commit 5bff87c5c64ad85c01875648ecdc122059ee7519
4 changes: 2 additions & 2 deletions tools/doc/type-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ function toLink(typeInput) {
typeTexts.forEach((typeText) => {
typeText = typeText.trim();
if (typeText) {
let typeUrl = null;
let typeUrl;

// To support type[], type[][] etc., we store the full string
// and use the bracket-less version to lookup the type URL.
Expand All @@ -143,7 +143,7 @@ function toLink(typeInput) {
typeUrl = `${jsDataStructuresUrl}#${primitive}_type`;
} else if (jsGlobalTypes.includes(typeText)) {
typeUrl = `${jsGlobalObjectsUrl}${typeText}`;
} else if (customTypesMap[typeText]) {
} else {
typeUrl = customTypesMap[typeText];
}

Expand Down