Skip to content

assert: minor assert error message improvements #20315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 3 commits into from
Closed

assert: minor assert error message improvements #20315

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0757b9b
assert: minor error message improvements
BridgeAR Apr 26, 2018
bef57a6
assert: make skipping indicator blue
BridgeAR Apr 26, 2018
52eb7e6
fixup ...
BridgeAR Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
assert: minor error message improvements 
Adjust indentations and fix a typo.
  • Loading branch information
@BridgeAR
BridgeAR committed Apr 26, 2018
commit 0757b9b292e11144213fd91ae4939b28161fcb2f
15 changes: 6 additions & 9 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,13 +360,10 @@ function createErrDiff(actual, expected, operator) {

// Strict equal with identical objects that are not identical by reference.
if (identical === maxLines) {
let base = 'Input object identical but not reference equal:';

if (operator !== 'strictEqual') {
// This code path should not be possible to reach.
// The output is identical but it is not clear why.
base = 'Input objects not identical:';
}
// E.g., assert.deepStrictEqual(Symbol(), Symbol())
const base = operator === 'strictEqual' ?
'Input objects identical but not reference equal:' :
'Input objects not identical:';

// We have to get the result again. The lines were all removed before.
const actualLines = inspectValue(actual);
Expand All @@ -380,7 +377,7 @@ function createErrDiff(actual, expected, operator) {
}
}

return `${base}\n\n ${actualLines.join('\n ')}\n`;
return `${base}\n\n${actualLines.join('\n')}\n`;
}
return `${msg}${skipped ? skippedMsg : ''}\n${res}${other}${end}`;
}
Expand Down Expand Up @@ -448,7 +445,7 @@ class AssertionError extends Error {
if (res.length === 1) {
super(`${base} ${res[0]}`);
} else {
super(`${base}\n\n ${res.join('\n ')}\n`);
super(`${base}\n\n${res.join('\n')}\n`);
}
} else {
let res = util.inspect(actual);
Expand Down
7 changes: 3 additions & 4 deletions test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,14 +599,13 @@ assert.throws(
});

// notDeepEqual tests
message = 'Identical input passed to notDeepStrictEqual:\n\n' +
' [\n 1\n ]\n';
message = 'Identical input passed to notDeepStrictEqual:\n\n[\n 1\n]\n';
assert.throws(
() => assert.notDeepEqual([1], [1]),
{ message });

message = 'Identical input passed to notDeepStrictEqual:' +
`\n\n [${'\n 1,'.repeat(25)}\n ...\n`;
`\n\n[${'\n 1,'.repeat(25)}\n...\n`;
const data = Array(31).fill(1);
assert.throws(
() => assert.notDeepEqual(data, data),
Expand Down Expand Up @@ -901,7 +900,7 @@ assert.throws(() => { throw null; }, 'foo');
assert.throws(
() => assert.strictEqual([], []),
{
message: 'Input object identical but not reference equal:\n\n []\n'
message: 'Input objects identical but not reference equal:\n\n[]\n'
}
);

Expand Down