Skip to content

fs/promises: ensure options.flag is defaulted to 'r' in readFile #20268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdistin wants to merge 4 commits into from
Closed

fs/promises: ensure options.flag is defaulted to 'r' in readFile #20268

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5a462f
fs/promises: ensure options.flag is defaulted to 'r' in readFile
bdistin May 9, 2018
26bce85
test: requested change
bdistin May 27, 2018
ca44fc2
test: fix requested change
bdistin May 27, 2018
543f297
fs: return string on empty fs.promises.readFile() when encoding provided
bdistin May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: requested change 
fail on unhandled rejection
  • Loading branch information
@bdistin
bdistin committed May 27, 2018
commit 26bce853b4a2ca643b1e80af4da80cdd067f0794
2 changes: 2 additions & 0 deletions test/parallel/test-fs-promises-readfile-empty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ const fixtures = require('../common/fixtures');

const fn = fixtures.path('empty.txt');

This comment was marked as resolved.

Sign in to view


common.crashOnUnhandledRejection();

fs.readFile(fn)
.then(assert.ok);

Expand Down