Skip to content

src: exit on gc unhandled rejection #20097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 6 commits into from
Closed

src: exit on gc unhandled rejection #20097

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ed1985
deps: fix V8_PROMISE_INTERNAL_FIELD_COUNT in features.gypi
BridgeAR Apr 25, 2018
1eef8cf
src: exit on gc unhandled rejection
BridgeAR Apr 16, 2018
46b0c97
process: stop rejection loop early
BridgeAR Jun 10, 2018
5218bb2
process: do not run extra microtasks
BridgeAR Jun 10, 2018
2dfe16a
fixup: further doc improvements and add todo
BridgeAR Jun 11, 2018
637824f
fixup: address targos comments
BridgeAR Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
process: stop rejection loop early 
This adds a fast path to the unhandledRejections and handledRejections
to actually stop trying to emit something if no hook is attached.
  • Loading branch information
@BridgeAR
BridgeAR committed Sep 5, 2018
commit 46b0c97bca7a25f491552b77116aecb8e0dfc83a
15 changes: 13 additions & 2 deletions lib/internal/process/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ const { ERR_INVALID_ENV_VALUE } = require('internal/errors').codes;
const { safeToString } = process.binding('util');

const maybeUnhandledPromises = new WeakMap();
const pendingUnhandledRejections = [];
const asyncHandledRejections = [];
let pendingUnhandledRejections = [];
let asyncHandledRejections = [];
const kFromPromise = true;
let lastPromiseId = 0;

Expand Down Expand Up @@ -105,6 +105,10 @@ function emitPromiseRejectionWarnings() {
const { promise, warning } = asyncHandledRejections.shift();
if (!process.emit('rejectionHandled', promise)) {
process.emitWarning(warning);
} else {
// Stop the loop early.
asyncHandledRejections = [];
break;
}
}
}
Expand Down Expand Up @@ -141,6 +145,13 @@ function emitPromiseRejectionWarnings() {
} else if (!process.emit('unhandledRejection', reason, promise)) {
if (state === kWarn || state === kErrorOnGC) {
emitWarning(uid, reason);
// Stop the loop as soon as possible. Since the handler might have been
// attached in the beginning and then removed again and a new unhandled
// rejection might have been added at that former state, only stop if no
// new rejections were added.
} else if (len === pendingUnhandledRejections.length) {
pendingUnhandledRejections = [];
break;
}
} else {
hadListeners = true;
Expand Down