Skip to content

Fixup few things after latest rebase #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevnorris wants to merge 2 commits into from
Closed

Fixup few things after latest rebase #2003

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
161b968
buffer: fix usage of kMaxLength
trevnorris Jun 17, 2015
0203645
buffer: minor cleanup from rebase
trevnorris Jun 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
buffer: minor cleanup from rebase
  • Loading branch information
@trevnorris
trevnorris committed Jun 17, 2015
commit 020364564c502e849a1b9d79f2562abaded91081
11 changes: 1 addition & 10 deletions lib/internal/buffer_new.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,16 +457,7 @@ Buffer.prototype.write = function(string, offset, length, encoding) {

// XXX legacy write(string, encoding, offset, length) - remove in v0.13
} else {
if (!writeWarned) {
if (process.throwDeprecation)
throw new Error(writeMsg);
else if (process.traceDeprecation)
console.trace(writeMsg);
else
console.error(writeMsg);
writeWarned = true;
}

writeWarned = internalUtil.printDeprecationMessage(writeMsg, writeWarned);
var swap = encoding;
encoding = offset;
offset = length >>> 0;
Expand Down