Skip to content

deps: update V8 to 6.7 #19989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 15 commits into from
Closed

deps: update V8 to 6.7 #19989

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
216a761
deps: update V8 to 6.7.288.43
targos May 31, 2018
fa8d330
build: reset embedder string to "-node.0"
targos May 31, 2018
2dc9890
deps: update v8.gyp
targos Mar 13, 2018
5d0ff08
deps: cherry-pick 39d546a from upstream V8
devsnek Apr 13, 2018
eccc509
v8: backport 9fb02b526f1cd3b859a530a01adb08bc0d089f4f
devsnek May 7, 2018
2887869
deps: cherry-pick 23652c5f from upstream V8
May 16, 2018
82368b3
deps: cherry-pick ff0a9793334 from upstream V8
addaleax May 18, 2018
f835b2e
deps: backport 91ddb65d from upstream V8
MayaLekova May 14, 2018
4b5b1a9
deps: cherry-pick 6989b3f6d7 from V8 upstream
TimothyGu May 18, 2018
4e90e9f
util: add type check function for BigIntObject
targos Mar 13, 2018
aa942b8
Revert "src: fix GetCpuProfiler() deprecation warning"
targos Apr 12, 2018
485e080
src: fix GetCpuProfiler() deprecation warning
targos Mar 23, 2018
ede9f16
test: add read_only_space heap space
cjihrig Mar 27, 2018
53725c9
test: update postmortem metadata test
cjihrig Mar 27, 2018
daa55f2
src: update postmortem constant name
cjihrig Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "src: fix GetCpuProfiler() deprecation warning" 
This reverts commit f02b74d.
  • Loading branch information
@targos
targos committed May 31, 2018
commit aa942b8e00488a912606f0b90ae34f999191aee6
14 changes: 3 additions & 11 deletions src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include "node_internals.h"
#include "async_wrap.h"
#include "v8-profiler.h"
#include "node_buffer.h"
#include "node_platform.h"
#include "node_file.h"
Expand Down Expand Up @@ -73,15 +74,6 @@ IsolateData::IsolateData(Isolate* isolate,
IsolateData::~IsolateData() {
if (platform_ != nullptr)
platform_->UnregisterIsolate(this);
if (cpu_profiler_ != nullptr)
cpu_profiler_->Dispose();
}

v8::CpuProfiler* IsolateData::GetCpuProfiler() {
if (cpu_profiler_ != nullptr) return cpu_profiler_;
cpu_profiler_ = v8::CpuProfiler::New(isolate());
CHECK_NOT_NULL(cpu_profiler_);
return cpu_profiler_;
}


Expand Down Expand Up @@ -260,12 +252,12 @@ void Environment::CleanupHandles() {
void Environment::StartProfilerIdleNotifier() {
uv_prepare_start(&idle_prepare_handle_, [](uv_prepare_t* handle) {
Environment* env = ContainerOf(&Environment::idle_prepare_handle_, handle);
env->isolate_data()->GetCpuProfiler()->SetIdle(true);
env->isolate()->GetCpuProfiler()->SetIdle(true);
});

uv_check_start(&idle_check_handle_, [](uv_check_t* handle) {
Environment* env = ContainerOf(&Environment::idle_check_handle_, handle);
env->isolate_data()->GetCpuProfiler()->SetIdle(false);
env->isolate()->GetCpuProfiler()->SetIdle(false);
});
}

Expand Down
4 changes: 0 additions & 4 deletions src/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
#include "req_wrap.h"
#include "util.h"
#include "uv.h"
#include "v8-profiler.h"
#include "v8.h"
#include "node.h"
#include "node_http2_state.h"
Expand Down Expand Up @@ -369,8 +368,6 @@ class IsolateData {
std::unordered_map<nghttp2_rcbuf*, v8::Eternal<v8::String>> http2_static_strs;
inline v8::Isolate* isolate() const;

v8::CpuProfiler* GetCpuProfiler();

private:
#define VP(PropertyName, StringValue) V(v8::Private, PropertyName)
#define VS(PropertyName, StringValue) V(v8::String, PropertyName)
Expand All @@ -386,7 +383,6 @@ class IsolateData {
uv_loop_t* const event_loop_;
uint32_t* const zero_fill_field_;
MultiIsolatePlatform* platform_;
v8::CpuProfiler* cpu_profiler_ = nullptr;

DISALLOW_COPY_AND_ASSIGN(IsolateData);
};
Expand Down