Skip to content

src: limit foreground tasks draining loop #19987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulan wants to merge 5 commits into from
Closed

src: limit foreground tasks draining loop #19987

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66a7421
src: limit foreground tasks draining loop
ulan Apr 12, 2018
4dbc4aa
[squash] clarify the comment of flushing
ulan Apr 13, 2018
c435401
[squash] fix the repost count in the new test.
ulan Apr 16, 2018
167ae0e
[squash] drain all tasks in inspector-agent.
ulan Apr 20, 2018
f46763b
[squash] fix comment s/iff/if/.
ulan Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] fix comment s/iff/if/.
  • Loading branch information
@ulan
ulan committed Apr 20, 2018
commit f46763bffee2e42407b72f9fc50b5caf335ac908
4 changes: 2 additions & 2 deletions src/node_platform.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class PerIsolatePlatformData :
void ref();
int unref();

// Returns true iff work was dispatched or executed. New tasks that are
// Returns true if work was dispatched or executed. New tasks that are
// posted during flushing of the queue are postponed until the next
// flushing.
bool FlushForegroundTasksInternal();
Expand Down Expand Up @@ -133,7 +133,7 @@ class NodePlatform : public MultiIsolatePlatform {
double CurrentClockTimeMillis() override;
v8::TracingController* GetTracingController() override;

// Returns true iff work was dispatched or executed. New tasks that are
// Returns true if work was dispatched or executed. New tasks that are
// posted during flushing of the queue are postponed until the next
// flushing.
bool FlushForegroundTasks(v8::Isolate* isolate);
Expand Down