Skip to content

tools: include exit code in test failures #19855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

tools: include exit code in test failures #19855

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdcd041
tools: include exit code in test failures
Trott Apr 6, 2018
0a797a9
tools: include exit code in TAP log
refack Apr 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tools: include exit code in TAP log
  • Loading branch information
@refack
refack committed Apr 10, 2018
commit 0a797a9180a296d1df17413ec2fdfb2020e42fda
13 changes: 8 additions & 5 deletions tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,12 @@ def HasRun(self, output):

class TapProgressIndicator(SimpleProgressIndicator):

def _printDiagnostic(self, traceback, severity):
logger.info(' severity: %s', severity)
def _printDiagnostic(self):
logger.info(' severity: %s', self.severity)
self.exitcode and logger.info(' exitcode: %s', self.exitcode)
logger.info(' stack: |-')

for l in traceback.splitlines():
for l in self.traceback.splitlines():
logger.info(' ' + l)

def Starting(self):
Expand All @@ -273,6 +274,7 @@ def HasRun(self, output):
self._done += 1
self.traceback = ''
self.severity = 'ok'
self.exitcode = ''

# Print test name as (for example) "parallel/test-assert". Tests that are
# scraped from the addons documentation are all named test.js, making it
Expand All @@ -284,7 +286,8 @@ def HasRun(self, output):
if output.UnexpectedOutput():
status_line = 'not ok %i %s' % (self._done, command)
self.severity = 'fail'
self.traceback = "exit code: " + output.output.exit_code + "\n" + output.output.stdout + output.output.stderr
self.exitcode = output.output.exit_code
self.traceback = output.output.stdout + output.output.stderr

if FLAKY in output.test.outcomes and self.flaky_tests_mode == DONTCARE:
status_line = status_line + ' # TODO : Fix flaky test'
Expand Down Expand Up @@ -330,7 +333,7 @@ def HasRun(self, output):
if self.severity is not 'ok' or self.traceback is not '':
if output.HasTimedOut():
self.traceback = 'timeout'
self._printDiagnostic(self.traceback, self.severity)
self._printDiagnostic()
logger.info(' ...')

def Done(self):
Expand Down