Skip to content

http2: invoke connect callback immediately if session was connected #19842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pietermees wants to merge 3 commits into from
Closed

http2: invoke connect callback immediately if session was connected #19842

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e785e66
doc: add Http2Session.connecting property
pietermees Apr 6, 2018
29036ab
http2: emit session connect on next tick
pietermees Apr 9, 2018
e9f09bd
test: add test for http2 session connect callback on already connecte…
pietermees Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http2: emit session connect on next tick
  • Loading branch information
@pietermees
pietermees committed Apr 9, 2018
commit 29036ab39316a64ba9fbc9ed0454f463d3219f65
4 changes: 2 additions & 2 deletions lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ function setupHandle(socket, type, options) {
// core will check for session.destroyed before progressing, this
// ensures that those at l`east get cleared out.
if (this.destroyed) {
this.emit('connect', this, socket);
process.nextTick(emit, this, 'connect', this, socket);
return;
}
debug(`Http2Session ${sessionName(type)}: setting up session handle`);
Expand Down Expand Up @@ -816,7 +816,7 @@ function setupHandle(socket, type, options) {
options.settings : {};

this.settings(settings);
this.emit('connect', this, socket);
process.nextTick(emit, this, 'connect', this, socket);
}

// Emits a close event followed by an error event if err is truthy. Used
Expand Down