Skip to content

add escapeCodeTimeout as an option to createInterface #19780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raoofha wants to merge 6 commits into from
Closed

add escapeCodeTimeout as an option to createInterface #19780

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
991174e
export ESCAPE_CODE_TIMEOUT
raoofha Apr 3, 2018
a58d9db
lib: add escapeCodeTimeout as an option to createInterface
Apr 4, 2018
0586244
test: add simple test to ensures escapeCodeTimeout option set correctly
Apr 4, 2018
b0b8ba5
lib: rewrite the same code for escapeCodeTimeout option
Apr 11, 2018
fb1ce38
lib: rewrite the same code again :)
May 15, 2018
5a25fd5
lib: rewrite the same code for the third time
May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
export ESCAPE_CODE_TIMEOUT
  • Loading branch information
@raoofha @refack
raoofha authored and refack committed Oct 16, 2018
commit 991174e3eedddf6c6381cd14776e86077d3d2d7f
8 changes: 3 additions & 5 deletions lib/readline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ const lineEnding = /\r?\n|\r(?!\n)/;
const KEYPRESS_DECODER = Symbol('keypress-decoder');
const ESCAPE_DECODER = Symbol('escape-decoder');

// GNU readline library - keyseq-timeout is 500ms (default)
const ESCAPE_CODE_TIMEOUT = 500;

function createInterface(input, output, completer, terminal) {
return new Interface(input, output, completer, terminal);
}
Expand Down Expand Up @@ -1020,7 +1017,7 @@ function emitKeypressEvents(stream, iface) {
stream[ESCAPE_DECODER].next(r[i]);
// Escape letter at the tail position
if (r[i] === kEscape && i + 1 === r.length) {
timeoutId = setTimeout(escapeCodeTimeout, ESCAPE_CODE_TIMEOUT);
timeoutId = setTimeout(escapeCodeTimeout, module.exports.ESCAPE_CODE_TIMEOUT);
}
} catch (err) {
// if the generator throws (it could happen in the `keypress`
Expand Down Expand Up @@ -1139,5 +1136,6 @@ module.exports = {
createInterface,
cursorTo,
emitKeypressEvents,
moveCursor
moveCursor,
ESCAPE_CODE_TIMEOUT : 500 // GNU readline library - keyseq-timeout is 500ms (default)
Copy link
Copy Markdown
Member

@jasnell jasnell Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to do this, passing escapeCodeTimeout as an option to readline.createInterface() would seem to be the better approach.

};